fix(analysis): Make AnalysisRun end when only Dry-Run metrics are defined. Fixes: #2151 #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawroh
force-pushed
the
dry-run-ana-fix
branch
from
18590b3
to
3aea03b
Compare
Codecov ReportBase: 82.35% // Head: 82.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2230 +/- ##
=======================================
Coverage 82.35% 82.36%
=======================================
Files 121 121
Lines 18434 18438 +4
=======================================
+ Hits 15182 15186 +4
Misses 2466 2466
Partials 786 786
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
chrisplim
reviewed
Sep 6, 2022
Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
dry-run-ana-fix
branch
from
3aea03b
to
543fa74
Compare
harikrongali
approved these changes
Sep 16, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
@agrawroh thanks for the fix and @harikrongali thanks for the review! |
jessesuen
approved these changes
Sep 22, 2022
daixijun
pushed a commit
to daixijun/argo-rollouts
that referenced
this pull request
Sep 27, 2022
…oproj#2230) Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: Xijun Dai <[email protected]>
leoluz
pushed a commit
that referenced
this pull request
Oct 6, 2022
Signed-off-by: Rohit Agrawal <[email protected]>
jenciso
pushed a commit
to jenciso/argo-rollouts
that referenced
this pull request
Oct 25, 2022
…oproj#2230) Signed-off-by: Rohit Agrawal <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
…oproj#2230) Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue defined in #2151 where
AnalysisRundoesn't transition toSuccessfulfromRunningwhen only Dry-Run metrics are defined and being evaluated. As per the current logic, we don't set the decision while evaluating the Dry-Run metrics but the proper fix is to set it toSuccessfulat least if nothing is set.Checklist
"fix(controller): Updates such and such. Fixes #1234".