Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter "L" doesn't work after navigating to a rollout details page #2273

Closed
2 tasks done
Cylix opened this issue Sep 29, 2022 · 2 comments · Fixed by #2723
Closed
2 tasks done

Letter "L" doesn't work after navigating to a rollout details page #2273

Cylix opened this issue Sep 29, 2022 · 2 comments · Fixed by #2723
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Milestone

Comments

@Cylix
Copy link
Contributor

Cylix commented Sep 29, 2022

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

Search inputs on the UI do not accept the letter "L" after navigating to a rollout details page.

The bug only seem to affect the letter "L". It is probably due to a shortcut implementation since the letter "L" seems to be used for navigating back to the dashboard root page.

To Reproduce

  1. Navigate to the Argo Rollouts Dashboard
  2. Try to input the letter "L" in the namespace or rollout search bars: it works 👍
  3. Navigate to a Rollout Details Page
  4. Try to input the letter "L" in the namespace or rollout search bars: it doesn't work anymore 🤯

Expected behavior

We should be able to input the letter "L" in search inputs.

Screenshots

Version

v1.2.1+51c874c

Logs

No logs, this is a UI issue. There are no logs in the browser console.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@Cylix Cylix added the bug Something isn't working label Sep 29, 2022
@dcortright
Copy link

@zachaller I would like to take this up for Hacktoberfest.

@zachaller
Copy link
Collaborator

Sounds good and thanks for jumping in. Feel free to reach out if you need anything!

@harikrongali harikrongali added this to the v1.4 milestone Oct 20, 2022
@zachaller zachaller modified the milestones: v1.4, v1.5 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants