Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add github action for PR Conventional Commits #2320

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

zachaller
Copy link
Collaborator

Signed-off-by: zachaller [email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Go Published Test Results

1 778 tests   1 778 ✔️  2m 30s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit b37c41f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 82.76% // Head: 82.76% // No change to project coverage 👍

Coverage data is based on head (b37c41f) compared to base (ff29d93).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2320   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         121      121           
  Lines       18522    18522           
=======================================
  Hits        15330    15330           
  Misses       2408     2408           
  Partials      784      784           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

E2E Tests Published Test Results

89 tests   86 ✔️  44m 28s ⏱️
  1 suites    3 💤
  1 files      0

Results for commit b37c41f.

♻️ This comment has been updated with latest results.

@zachaller zachaller added this to the v1.4 milestone Oct 13, 2022
@zachaller zachaller added the ready-for-review Ready for final review label Oct 14, 2022
@zachaller zachaller changed the title feat(ci): Add github action for PR Conventional Commits ci: Add github action for PR Conventional Commits Oct 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayzhang2000 mayzhang2000 merged commit f99d3ec into argoproj:master Oct 14, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
* feat(ci): Add github action for PR Conventional Commits

Signed-off-by: zachaller <[email protected]>

* add example scope

Signed-off-by: zachaller <[email protected]>

* add cli as scope

Signed-off-by: zachaller <[email protected]>

* Remove configuration

Signed-off-by: zachaller <[email protected]>

* scopes not required

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
* feat(ci): Add github action for PR Conventional Commits

Signed-off-by: zachaller <[email protected]>

* add example scope

Signed-off-by: zachaller <[email protected]>

* add cli as scope

Signed-off-by: zachaller <[email protected]>

* Remove configuration

Signed-off-by: zachaller <[email protected]>

* scopes not required

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
* feat(ci): Add github action for PR Conventional Commits

Signed-off-by: zachaller <[email protected]>

* add example scope

Signed-off-by: zachaller <[email protected]>

* add cli as scope

Signed-off-by: zachaller <[email protected]>

* Remove configuration

Signed-off-by: zachaller <[email protected]>

* scopes not required

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants