Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): add support for getting the replicaset name via templating #2396

Conversation

zachaller
Copy link
Collaborator

Signed-off-by: zachaller [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Go Published Test Results

1 778 tests   1 778 ✔️  2m 29s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit d9e4615.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 82.76% // Head: 82.76% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d9e4615) compared to base (076ea43).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2396   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         121      121           
  Lines       18536    18537    +1     
=======================================
+ Hits        15341    15342    +1     
  Misses       2410     2410           
  Partials      785      785           
Impacted Files Coverage Δ
utils/template/template.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mayzhang2000 mayzhang2000 self-requested a review November 4, 2022 15:14
Copy link
Member

@alexef alexef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, by the looks of it this is just what I need

@mayzhang2000 mayzhang2000 removed their request for review November 4, 2022 15:18
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 31m 59s ⏱️
  89 tests   86 ✔️ 3 💤 0
178 runs  172 ✔️ 6 💤 0

Results for commit d9e4615.

@mayzhang2000 mayzhang2000 self-requested a review November 4, 2022 16:31
Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayzhang2000 mayzhang2000 merged commit 5f034a4 into argoproj:master Nov 4, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants