-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support N nginx ingresses #2467
feat: support N nginx ingresses #2467
Conversation
926b320
to
86fedec
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2467 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 133 133
Lines 19866 19944 +78
=======================================
+ Hits 16195 16259 +64
- Misses 2836 2849 +13
- Partials 835 836 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@zachaller - Is this targeted for 1.4? |
No I just cut 1.4 due to the timeline we are tracking with argocd but with this and the alb support also wanting the same features I plan on getting it megred in for 1.5 I do want to spend a little time looking at how we did it with istio and see if it makes sense to mimic that here vs the additionalIngesses and or for the alb as well to see if having a route concept makes sense or not, but I am pretty on board for the feature. |
@ssanders1449 also note I do want to follow a much more open release schedule here is the proposal https://github.com/argoproj/argo-rollouts/pull/2446/files |
eb18526
to
0cde28c
Compare
Signed-off-by: Travis Perdue <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
…ionalStableIngresses Signed-off-by: Travis Perdue <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
… more than 1 Nginix Ingress Controller Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
I'm working on reducing duplication today |
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@tperdue321 Can I get you to resolve conflicts before I review? |
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
…-nginx-ingresses Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Also can you update from master to resolve conflicts. |
Signed-off-by: Travis Perdue <[email protected]>
…-nginx-ingresses Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Enhancement proposal: #2001
Modifications:
Nginx
datatype to have a field calledAdditionalStableIngresses
to allow for 1-N stable ingresses instead of just 1. This naming convention is modeled afterAdditionalIngressAnnotations
SetWeight
method to create a canary for each stable ingress and apply new weight to all canary ingresses.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.