Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix checksum generation #2481

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Conversation

34fathombelow
Copy link
Member

Signed-off-by: Justin Marquis [email protected]

This PR fixes the checksum generation done during a release. Also included SBOM to be signed. Cosign public key added for public record.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

Go Published Test Results

1 832 tests   1 832 ✔️  2m 30s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit dcd4675.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 81.67% // Head: 81.67% // No change to project coverage 👍

Coverage data is based on head (dcd4675) compared to base (84df738).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2481   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files         126      126           
  Lines       19124    19124           
=======================================
  Hits        15620    15620           
  Misses       2710     2710           
  Partials      794      794           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    2 files      2 suites   1h 43m 52s ⏱️
  94 tests   86 ✔️ 3 💤 5
194 runs  182 ✔️ 6 💤 6

For more details on these failures, see this check.

Results for commit c8344da.

Signed-off-by: zachaller <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller
Copy link
Collaborator

Just an fyi, I removed the public cosing key, when I talked to Jesse about this and I think it makes sense as well we did not want to really publish a pub key outside of the release. The reason for this is if we ever need to rotate the private key if users are used to having to pull public keys from the release assets only it makes it really easy to rotate without having to have a notice of the leak and breaking newer releases from being checked if they are always just pulling the pub key from the release they will always have the correct key even if we switch. Do you see any issue with that?

@zachaller zachaller merged commit f5fb4c4 into argoproj:master Dec 15, 2022
@34fathombelow 34fathombelow deleted the fix-checksum branch December 15, 2022 14:51
zachaller added a commit that referenced this pull request Dec 15, 2022
* chore: fix checksum generation and sign sbom

Signed-off-by: Justin Marquis <[email protected]>

* cosign public key for public record

Signed-off-by: Justin Marquis <[email protected]>

* remove pub key for cosign

Signed-off-by: zachaller <[email protected]>

Signed-off-by: Justin Marquis <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* chore: fix checksum generation and sign sbom

Signed-off-by: Justin Marquis <[email protected]>

* cosign public key for public record

Signed-off-by: Justin Marquis <[email protected]>

* remove pub key for cosign

Signed-off-by: zachaller <[email protected]>

Signed-off-by: Justin Marquis <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* chore: fix checksum generation and sign sbom

Signed-off-by: Justin Marquis <[email protected]>

* cosign public key for public record

Signed-off-by: Justin Marquis <[email protected]>

* remove pub key for cosign

Signed-off-by: zachaller <[email protected]>

Signed-off-by: Justin Marquis <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants