fix: update GetTargetGroupMetadata to call DescribeTags in batches #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to: argoproj#2569 Signed-off-by: Chatchai Luangmanee <[email protected]>
format Signed-off-by: Chatchai Luangmanee <[email protected]>
chatchai-outreach
force-pushed
the
chatchai-outreach/fix/aws-describe-tag-batch
branch
from
fddc148
to
7600681
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 81.59% // Head: 81.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2570 +/- ##
==========================================
+ Coverage 81.59% 81.60% +0.01%
==========================================
Files 130 130
Lines 19469 19481 +12
==========================================
+ Hits 15886 15898 +12
Misses 2766 2766
Partials 817 817
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zachaller
approved these changes
Feb 8, 2023
chatchai-outreach
deleted the
chatchai-outreach/fix/aws-describe-tag-batch
branch
chatchai-outreach
added a commit
to getoutreach/argoproj-argo-rollouts
that referenced
this pull request
Feb 9, 2023
…rgoproj#2570) * update GetTargetGroupMetadata to call DescribeTags in batches related to: argoproj#2569 Signed-off-by: Chatchai Luangmanee <[email protected]> * Update defaults.go format Signed-off-by: Chatchai Luangmanee <[email protected]> --------- Signed-off-by: Chatchai Luangmanee <[email protected]>
zachaller
pushed a commit
that referenced
this pull request
Feb 24, 2023
…2570) * update GetTargetGroupMetadata to call DescribeTags in batches related to: #2569 Signed-off-by: Chatchai Luangmanee <[email protected]> * Update defaults.go format Signed-off-by: Chatchai Luangmanee <[email protected]> --------- Signed-off-by: Chatchai Luangmanee <[email protected]> Signed-off-by: zachaller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update GetTargetGroupMetadata to call DescribeTags in batches
DescribeTags allows up to 20 resources (ARNs) to be specified in a single call.
related to: #2569
closes: #2569
Signed-off-by: Chatchai Luangmanee [email protected]
Checklist:
"fix(controller): Updates such and such. Fixes #1234".