Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: analysis information box #2530 #2575

Merged

Conversation

schakrad
Copy link
Contributor

@schakrad schakrad commented Feb 8, 2023

fixes: #2530

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Before

Screen Shot 2023-02-07 at 11 20 46 PM

After

Screen Shot 2023-02-07 at 11 20 19 PM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Go Published Test Results

1 850 tests   1 850 ✔️  2m 32s ⏱️
   112 suites         0 💤
       1 files           0

Results for commit cdaa9f9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 41m 25s ⏱️
  95 tests   87 ✔️ 3 💤 5
196 runs  184 ✔️ 6 💤 6

For more details on these failures, see this check.

Results for commit cdaa9f9.

♻️ This comment has been updated with latest results.

@zachaller
Copy link
Collaborator

@schakrad can you run make codegen

@zachaller
Copy link
Collaborator

@schakrad no need to make codegen yet there was some upstream issue causing issues

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 81.59% // Head: 81.59% // No change to project coverage 👍

Coverage data is based on head (cdaa9f9) compared to base (a58064a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2575   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files         130      130           
  Lines       19469    19469           
=======================================
  Hits        15886    15886           
  Misses       2766     2766           
  Partials      817      817           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller merged commit 6fccbe6 into argoproj:master Feb 8, 2023
@Hronom
Copy link

Hronom commented Feb 26, 2023

Hey, when this will be available? I'm on 1.4.1 and issue still there:
image

@zachaller
Copy link
Collaborator

It just did not get cherry picked back onto 1.4.1 it will be fixed in 1.5 which is expected to release end of March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix analysis information box
4 participants