Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort doesn't revert old rollouts-pod-template-hash into canaryService #2576

Closed
2 tasks done
gasgurda opened this issue Feb 8, 2023 · 1 comment · Fixed by #2540
Closed
2 tasks done

Abort doesn't revert old rollouts-pod-template-hash into canaryService #2576

gasgurda opened this issue Feb 8, 2023 · 1 comment · Fixed by #2540
Labels
bug Something isn't working

Comments

@gasgurda
Copy link

gasgurda commented Feb 8, 2023 •
edited
Loading

Checklist:

  • I've included steps to reproduce the bug.
  • I've inclued the version of argo rollouts.

Describe the bug

Abort doesn't bring back old rollouts-pod-template-hash into canaryService.

To Reproduce

rollout.yml

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  name: rollouts-demo
spec:
  replicas: 3
  strategy:
    canary:
      canaryService: rollouts-demo-canary
      stableService: rollouts-demo-stable
      trafficRouting:
        smi:
          rootService: rollouts-demo
      steps:
      - setWeight: 20
      - pause: {}
      - setWeight: 50
      - pause: {duration: 20}
  revisionHistoryLimit: 2
  selector:
    matchLabels:
      app: rollouts-demo
  template:
    metadata:
      labels:
        app: rollouts-demo
    spec:
      containers:
      - name: rollouts-demo
        image: argoproj/rollouts-demo:blue
        ports:
        - name: http
          containerPort: 8080
          protocol: TCP

services.yml

apiVersion: v1
kind: Service
metadata:
  name: rollouts-demo-canary
spec:
  ports:
  - port: 8080
    targetPort: 8080
    protocol: TCP
  selector:
    app: rollouts-demo
    # This selector will be updated with the pod-template-hash of the canary ReplicaSet. e.g.:
    # rollouts-pod-template-hash: 7bf84f9696
---
apiVersion: v1
kind: Service
metadata:
  name: rollouts-demo-stable
spec:
  ports:
  - port: 8080
    targetPort: 8080
    protocol: TCP
  selector:
    app: rollouts-demo
    # This selector will be updated with the pod-template-hash of the stable ReplicaSet. e.g.:
    # rollouts-pod-template-hash: 789746c88d
---
apiVersion: v1
kind: Service
metadata:
  name: rollouts-demo
spec:
  ports:
  - port: 8080
    targetPort: 8080
    protocol: TCP
  selector:
    app: rollouts-demo

`$ kubectl apply -f services.yml -f rollout.yml
$ k get svc rollouts-demo-canary rollouts-demo-stable -o yaml | grep hash
hashes will be the same
$ kubectl argo rollouts set image rollouts-demo rollouts-demo=argoproj/rollouts-demo:red
$ k get svc rollouts-demo-canary rollouts-demo-stable -o yaml | grep hash
hashes will be different
$ kubectl argo rollouts abort rollouts-demo
$ k get svc rollouts-demo-canary rollouts-demo-stable -o yaml | grep hash
hashes will be different but must be the same

Expected behavior

After abort, canaryService rollouts-demo-canary must bring back old rollouts-pod-template-has

Screenshots

Version

argo-rollouts:v1.4.0
Logs

# Paste the logs from the rollout controller

# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts

# Logs for a specific rollout:

time="2023-02-08T13:59:07Z" level=info msg="Start processing" resource=ops/rollouts-demo
time="2023-02-08T13:59:07Z" level=error msg="Failed to process: secret \"argo-rollouts-notification-secret\" not found" resource=ops/rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56129837 rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Previous weights: &TrafficWeights{Canary:WeightDestination{Weight:20,ServiceName:rollouts-demo-canary,PodTemplateHash:5447f4d8b7,},Stable:WeightDestination{Weight:80,ServiceName:rollouts-demo-stable,PodTemplateHash:85d9c774bc,},Additional:[]WeightDestination{},Verified:nil,}" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="New weights: &TrafficWeights{Canary:WeightDestination{Weight:0,ServiceName:rollouts-demo-canary,PodTemplateHash:5447f4d8b7,},Stable:WeightDestination{Weight:100,ServiceName:rollouts-demo-stable,PodTemplateHash:85d9c774bc,},Additional:[]WeightDestination{},Verified:nil,}" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="subsFromAnnotations: map[kubectl.kubernetes.io/last-applied-configuration:{\"apiVersion\":\"argoproj.io/v1alpha1\",\"kind\":\"Rollout\",\"metadata\":{\"annotations\":{},\"name\":\"rollouts-demo\",\"namespace\":\"ops\"},\"spec\":{\"replicas\":3,\"revisionHistoryLimit\":2,\"selector\":{\"matchLabels\":{\"app\":\"rollouts-demo\"}},\"strategy\":{\"canary\":{\"canaryService\":\"rollouts-demo-canary\",\"stableService\":\"rollouts-demo-stable\",\"steps\":[{\"setWeight\":20},{\"pause\":{}},{\"setWeight\":50},{\"pause\":{\"duration\":20}}],\"trafficRouting\":{\"smi\":{\"rootService\":\"rollouts-demo\"}}}},\"template\":{\"metadata\":{\"labels\":{\"app\":\"rollouts-demo\"}},\"spec\":{\"containers\":[{\"image\":\"argoproj/rollouts-demo:blue\",\"name\":\"rollouts-demo\",\"ports\":[{\"containerPort\":8080,\"name\":\"http\",\"protocol\":\"TCP\"}]}]}}}}\n rollout.argoproj.io/revision:2]" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Traffic weight updated from 20 to 0" event_reason=TrafficWeightUpdated namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: false, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Event(v1.ObjectReference{Kind:\"Rollout\", Namespace:\"ops\", Name:\"rollouts-demo\", UID:\"dd9c0f5d-7fcd-4e24-9037-c531e85a300d\", APIVersion:\"argoproj.io/v1alpha1\", ResourceVersion:\"56129837\", FieldPath:\"\"}): type: 'Normal' reason: 'TrafficWeightUpdated' Traffic weight updated from 20 to 0"
time="2023-02-08T13:59:07Z" level=info msg="Set 'scale-down-deadline' annotation on 'rollouts-demo-5447f4d8b7' to 2023-02-08T13:59:37Z (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Reconciling canary pause step (stepIndex: 1/4)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Not finished reconciling Canary Pause" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Enqueueing parent of ops/rollouts-demo-5447f4d8b7: Rollout ops/rollouts-demo"
time="2023-02-08T13:59:07Z" level=info msg="subsFromAnnotations: map[kubectl.kubernetes.io/last-applied-configuration:{\"apiVersion\":\"argoproj.io/v1alpha1\",\"kind\":\"Rollout\",\"metadata\":{\"annotations\":{},\"name\":\"rollouts-demo\",\"namespace\":\"ops\"},\"spec\":{\"replicas\":3,\"revisionHistoryLimit\":2,\"selector\":{\"matchLabels\":{\"app\":\"rollouts-demo\"}},\"strategy\":{\"canary\":{\"canaryService\":\"rollouts-demo-canary\",\"stableService\":\"rollouts-demo-stable\",\"steps\":[{\"setWeight\":20},{\"pause\":{}},{\"setWeight\":50},{\"pause\":{\"duration\":20}}],\"trafficRouting\":{\"smi\":{\"rootService\":\"rollouts-demo\"}}}},\"template\":{\"metadata\":{\"labels\":{\"app\":\"rollouts-demo\"}},\"spec\":{\"containers\":[{\"image\":\"argoproj/rollouts-demo:blue\",\"name\":\"rollouts-demo\",\"ports\":[{\"containerPort\":8080,\"name\":\"http\",\"protocol\":\"TCP\"}]}]}}}}\n rollout.argoproj.io/revision:2]" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=warning msg="Rollout aborted update to revision 2" event_reason=RolloutAborted namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Event(v1.ObjectReference{Kind:\"Rollout\", Namespace:\"ops\", Name:\"rollouts-demo\", UID:\"dd9c0f5d-7fcd-4e24-9037-c531e85a300d\", APIVersion:\"argoproj.io/v1alpha1\", ResourceVersion:\"56129837\", FieldPath:\"\"}): type: 'Warning' reason: 'RolloutAborted' Rollout aborted update to revision 2"
time="2023-02-08T13:59:07Z" level=info msg="Patched: {\"status\":{\"abortedAt\":\"2023-02-08T13:59:07Z\",\"canary\":{\"weights\":{\"canary\":{\"weight\":0},\"stable\":{\"weight\":100}}},\"conditions\":[{\"lastTransitionTime\":\"2023-02-08T13:58:01Z\",\"lastUpdateTime\":\"2023-02-08T13:58:01Z\",\"message\":\"Rollout has minimum availability\",\"reason\":\"AvailableReason\",\"status\":\"True\",\"type\":\"Available\"},{\"lastTransitionTime\":\"2023-02-08T13:58:50Z\",\"lastUpdateTime\":\"2023-02-08T13:58:50Z\",\"message\":\"Rollout is not healthy\",\"reason\":\"RolloutHealthy\",\"status\":\"False\",\"type\":\"Healthy\"},{\"lastTransitionTime\":\"2023-02-08T13:58:50Z\",\"lastUpdateTime\":\"2023-02-08T13:58:50Z\",\"message\":\"RolloutCompleted\",\"reason\":\"RolloutCompleted\",\"status\":\"False\",\"type\":\"Completed\"},{\"lastTransitionTime\":\"2023-02-08T13:58:51Z\",\"lastUpdateTime\":\"2023-02-08T13:58:51Z\",\"message\":\"Rollout is paused\",\"reason\":\"RolloutPaused\",\"status\":\"True\",\"type\":\"Paused\"},{\"lastTransitionTime\":\"2023-02-08T13:59:07Z\",\"lastUpdateTime\":\"2023-02-08T13:59:07Z\",\"message\":\"Rollout aborted update to revision 2\",\"reason\":\"RolloutAborted\",\"status\":\"False\",\"type\":\"Progressing\"}],\"controllerPause\":null,\"currentStepIndex\":0,\"message\":\"RolloutAborted: Rollout aborted update to revision 2\",\"pauseConditions\":null,\"phase\":\"Degraded\"}}" generation=3 namespace=ops resourceVersion=56129837 rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="persisted to informer" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56129837 rollout=rollouts-demo time_ms=42.957571
time="2023-02-08T13:59:07Z" level=info msg="Start processing" resource=ops/rollouts-demo
time="2023-02-08T13:59:07Z" level=error msg="Failed to process: secret \"argo-rollouts-notification-secret\" not found" resource=ops/rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has not reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo time_ms=4.944678
time="2023-02-08T13:59:07Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has not reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:07Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo time_ms=4.263813
time="2023-02-08T13:59:37Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Enqueueing parent of ops/rollouts-demo-5447f4d8b7: Rollout ops/rollouts-demo"
time="2023-02-08T13:59:37Z" level=info msg="subsFromAnnotations: map[kubectl.kubernetes.io/last-applied-configuration:{\"apiVersion\":\"argoproj.io/v1alpha1\",\"kind\":\"Rollout\",\"metadata\":{\"annotations\":{},\"name\":\"rollouts-demo\",\"namespace\":\"ops\"},\"spec\":{\"replicas\":3,\"revisionHistoryLimit\":2,\"selector\":{\"matchLabels\":{\"app\":\"rollouts-demo\"}},\"strategy\":{\"canary\":{\"canaryService\":\"rollouts-demo-canary\",\"stableService\":\"rollouts-demo-stable\",\"steps\":[{\"setWeight\":20},{\"pause\":{}},{\"setWeight\":50},{\"pause\":{\"duration\":20}}],\"trafficRouting\":{\"smi\":{\"rootService\":\"rollouts-demo\"}}}},\"template\":{\"metadata\":{\"labels\":{\"app\":\"rollouts-demo\"}},\"spec\":{\"containers\":[{\"image\":\"argoproj/rollouts-demo:blue\",\"name\":\"rollouts-demo\",\"ports\":[{\"containerPort\":8080,\"name\":\"http\",\"protocol\":\"TCP\"}]}]}}}}\n rollout.argoproj.io/revision:2]" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Scaled down ReplicaSet rollouts-demo-5447f4d8b7 (revision 2) from 1 to 0" event_reason=ScalingReplicaSet namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Not finished reconciling new ReplicaSet 'rollouts-demo-5447f4d8b7'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Not finished reconciling ReplicaSets" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Event(v1.ObjectReference{Kind:\"Rollout\", Namespace:\"ops\", Name:\"rollouts-demo\", UID:\"dd9c0f5d-7fcd-4e24-9037-c531e85a300d\", APIVersion:\"argoproj.io/v1alpha1\", ResourceVersion:\"56129842\", FieldPath:\"\"}): type: 'Normal' reason: 'ScalingReplicaSet' Scaled down ReplicaSet rollouts-demo-5447f4d8b7 (revision 2) from 1 to 0"
time="2023-02-08T13:59:37Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo time_ms=18.27401
time="2023-02-08T13:59:37Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo time_ms=9.594545
time="2023-02-08T13:59:37Z" level=info msg="Enqueueing parent of ops/rollouts-demo-5447f4d8b7: Rollout ops/rollouts-demo"
time="2023-02-08T13:59:37Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Enqueueing parent of ops/rollouts-demo-5447f4d8b7: Rollout ops/rollouts-demo"
time="2023-02-08T13:59:37Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo time_ms=9.22341
time="2023-02-08T13:59:37Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Patched: {\"status\":{\"HPAReplicas\":3,\"availableReplicas\":3,\"readyReplicas\":3,\"replicas\":3,\"updatedReplicas\":null}}" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="persisted to informer" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56129842 rollout=rollouts-demo time_ms=30.251616
time="2023-02-08T13:59:37Z" level=info msg="Start processing" resource=ops/rollouts-demo
time="2023-02-08T13:59:37Z" level=error msg="Failed to process: secret \"argo-rollouts-notification-secret\" not found" resource=ops/rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo
time="2023-02-08T13:59:37Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo time_ms=5.663379
time="2023-02-08T14:01:05Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Start processing" resource=ops/rollouts-demo
time="2023-02-08T14:01:05Z" level=error msg="Failed to process: secret \"argo-rollouts-notification-secret\" not found" resource=ops/rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo time_ms=5.682442
time="2023-02-08T14:01:05Z" level=info msg="syncing service" namespace=ops rollout=rollouts-demo service=rollouts-demo-canary
time="2023-02-08T14:01:05Z" level=info msg="syncing service" namespace=ops rollout=rollouts-demo service=rollouts-demo-stable
time="2023-02-08T14:01:05Z" level=info msg="Started syncing rollout" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Found 1 TrafficRouting Reconcilers" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Reconciling TrafficRouting with type 'SMI'" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Traffic Split `rollouts-demo` was not modified" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Skipping analysis: isAborted: true, promoteFull: false, rollbackToScaleDownDelay: true, initialDeploy: false" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Scale down new rs 'rollouts-demo-5447f4d8b7' on abort (30s)" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="New rs 'rollouts-demo-5447f4d8b7' has scaledown deadline annotation: 2023-02-08T13:59:37Z" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="RS 'rollouts-demo-5447f4d8b7' has reached the scaleDownTime" namespace=ops rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="No status changes. Skipping patch" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo
time="2023-02-08T14:01:05Z" level=info msg="Reconciliation completed" generation=3 namespace=ops resourceVersion=56130224 rollout=rollouts-demo time_ms=4.026942

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@gasgurda gasgurda added the bug Something isn't working label Feb 8, 2023
@zachaller zachaller mentioned this issue Feb 8, 2023
Merged
@zachaller
Copy link
Collaborator

This should be fixed by #2540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: switch service selector back to stable on canary service when aborted zachaller/argo-rollouts
2 participants
@zachaller @gasgurda