Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve e2e test timing #2577

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Feb 8, 2023

Rollback a version bump from dependabot in this commit 7fd92f5 the only change was to bump notification engine back to what it was pre this commit

Also improves an e2e test by not sleeping

@zachaller zachaller changed the title Chore improve e2e test timing chore: improve e2e test timing Feb 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@zachaller zachaller marked this pull request as ready for review February 8, 2023 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Go Published Test Results

1 850 tests   1 850 ✔️  2m 30s ⏱️
   112 suites         0 💤
       1 files           0

Results for commit 76d749f.

@zachaller zachaller requested a review from leoluz February 8, 2023 15:30
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 81.59% // Head: 81.59% // No change to project coverage 👍

Coverage data is based on head (76d749f) compared to base (5c9bc03).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2577   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files         130      130           
  Lines       19469    19469           
=======================================
  Hits        15886    15886           
  Misses       2766     2766           
  Partials      817      817           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 35m 2s ⏱️
  95 tests   88 ✔️ 3 💤 4
194 runs  184 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit 76d749f.

@zachaller zachaller merged commit a58064a into argoproj:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants