Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to distroless for cli/dashboard image #2596

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

zachaller
Copy link
Collaborator

fixes: #2594

Signed-off-by: zachaller <[email protected]>
@zachaller zachaller added this to the v1.5 milestone Feb 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

Go Published Test Results

1 850 tests   1 850 ✔️  2m 31s ⏱️
   112 suites         0 💤
       1 files           0

Results for commit aae55d5.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 81.59% // Head: 81.60% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (aae55d5) compared to base (33543d5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2596      +/-   ##
==========================================
+ Coverage   81.59%   81.60%   +0.01%     
==========================================
  Files         130      130              
  Lines       19483    19483              
==========================================
+ Hits        15897    15900       +3     
+ Misses       2769     2766       -3     
  Partials      817      817              
Impacted Files Coverage Δ
rollout/templateref.go 82.98% <0.00%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 39m 4s ⏱️
  96 tests   89 ✔️ 3 💤 4
196 runs  186 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit aae55d5.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this change makes sense

Copy link
Contributor

@tperdue321 tperdue321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for distroless

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 457272f into argoproj:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo Rollouts Dashboard Docker Image - Unsupported Host OS
4 participants