v1.4.0 Failed to create Service for template -- port.Name not being passed to CreateService

[bt-macole]

Checklist:

• I've included steps to reproduce the bug.
• I've inclued the version of argo rollouts.

Describe the bug

When creating the ports slice (code here) to pass to CreateService, port.Name is omitted, when attempting to create a Service where len(ports) > 1 this generates an invalid spec.

It seems this was not previously an issue because the created Service always only had the single hardcoded port. However, if more than 1 Service Port is defined, name is not optional (see k8s docs for more here)

To Reproduce

argo-rollouts: v1.4.x

Create an Experiment with more than 1 rs.spec.template.spec.containers.ports, such as:

example template.spec.containers.ports:

...
    template:
      ...
      spec:
      ...
        containers:
           ...
              ports:
                - containerPort: 8080
                  name: a
                - containerPort: 8082
                  name: b
                - containerPort: 8083
                  name: c
...

will get error such as:

        Failed to create Service for template '<SERVICE NAME>': Service
        "<UNIQUE-SERVICE-NAME>" is invalid:
        [spec.ports[0].name: Required value, spec.ports[1].name: Required value,
        spec.ports[2].name: Required value]

With degraded rollout and experiment resources.

Expected behavior

Experiment creates resources.

Version

v1.4.0

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[zachaller]

I think this is closed here can you confirm if this fixes the issue for you #2572

[bt-macole]

100% missed this, even though it is indeed in master already. apologies!