Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Adding status.alb.canaryTargetGroup.fullName for ALB. Fixes #2589 #2604

Merged
merged 13 commits into from
Feb 25, 2023

Conversation

danil-smirnov
Copy link
Contributor

@danil-smirnov danil-smirnov commented Feb 18, 2023

fixes: #2589

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 37m 27s ⏱️
  96 tests   89 ✔️ 3 💤 4
196 runs  186 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit 079dec1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

Go Published Test Results

1 859 tests   1 859 ✔️  2m 31s ⏱️
   113 suites         0 💤
       1 files           0

Results for commit 079dec1.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 81.52% // Head: 81.53% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (079dec1) compared to base (065d130).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2604      +/-   ##
==========================================
+ Coverage   81.52%   81.53%   +0.01%     
==========================================
  Files         131      131              
  Lines       19562    19578      +16     
==========================================
+ Hits        15947    15963      +16     
  Misses       2795     2795              
  Partials      820      820              
Impacted Files Coverage Δ
rollout/trafficrouting/alb/alb.go 79.08% <100.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

danil-smirnov and others added 11 commits February 21, 2023 22:18
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
rollout/trafficrouting/alb/alb.go Outdated Show resolved Hide resolved
rollout/trafficrouting/alb/alb.go Outdated Show resolved Hide resolved
rollout/trafficrouting/alb/alb_test.go Outdated Show resolved Hide resolved
Signed-off-by: Danil Smirnov <[email protected]>
Signed-off-by: Danil Smirnov <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
8.2% 8.2% Duplication

@zachaller zachaller changed the title fix(controller): Adding status.alb.canaryTargetGroup.fullName for ALB. Fixes #2589 feat(controller): Adding status.alb.canaryTargetGroup.fullName for ALB. Fixes #2589 Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALB Target Group name is not consistent with CloudWatch metrics dimensions
2 participants