Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update e2e k8s versions #2637

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Mar 3, 2023

run e2e tests on more current k8s versions, going forward 4 will be the most we support and will start dropping older versions.

I also updated the crd's from their upstreams for e2e tests.

I also fixed a bug with the tmate logic on manual runs, an empty string passes as true on actions and so we would always fall into debug mode.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Go Published Test Results

1 871 tests   1 871 ✔️  2m 30s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 360bf8b.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5318977) 81.50% compared to head (c211c6b) 81.50%.

❗ Current head c211c6b differs from pull request most recent head 360bf8b. Consider uploading reports for the commit 360bf8b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2637   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files         133      133           
  Lines       19852    19852           
=======================================
  Hits        16181    16181           
  Misses       2836     2836           
  Partials      835      835           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 7m 46s ⏱️
  94 tests   83 ✔️   5 💤 6
382 runs  356 ✔️ 20 💤 6

For more details on these failures, see this check.

Results for commit 360bf8b.

♻️ This comment has been updated with latest results.

@zachaller zachaller force-pushed the chore-update-e2e-k8s-versions branch from c211c6b to 360bf8b Compare March 3, 2023 17:54
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit b1a1e15 into argoproj:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants