Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analysis): Nil Pointer Fixes #2458 #2680

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

lewinkedrs
Copy link
Contributor

@lewinkedrs lewinkedrs commented Mar 24, 2023

Revision of #2489

Checklist:

  • [ b] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [c ] The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [ X] I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ X] My builds are green. Try syncing with master if they are not.
  • [ X] My organization is added to USERS.md.

Signed-off-by: Kevin Lewin <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lewinkedrs lewinkedrs changed the title Fixes #2458 fix(sigv4): Nil Pointer Fixes #2458 Mar 24, 2023
@lewinkedrs lewinkedrs changed the title fix(sigv4): Nil Pointer Fixes #2458 fix(analysis): Nil Pointer Fixes #2458 Mar 24, 2023
@github-actions
Copy link
Contributor

Go Published Test Results

1 877 tests   1 877 ✔️  2m 31s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 4fa2a4f.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aa47e41) 81.52% compared to head (4fa2a4f) 81.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2680   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         133      133           
  Lines       19866    19866           
=======================================
  Hits        16195    16195           
  Misses       2836     2836           
  Partials      835      835           
Impacted Files Coverage Δ
metricproviders/prometheus/prometheus.go 89.43% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 16m 36s ⏱️
  95 tests   83 ✔️   5 💤   7
396 runs  361 ✔️ 20 💤 15

For more details on these failures, see this check.

Results for commit 4fa2a4f.

@zachaller zachaller merged commit 874c188 into argoproj:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants