Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump k8s deps to v0.25.8 #2712

Merged
merged 7 commits into from
Apr 28, 2023
Merged

chore: bump k8s deps to v0.25.8 #2712

merged 7 commits into from
Apr 28, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Apr 12, 2023 •
edited
Loading

This just bumps the k8s deps, all the other changes where do to code gen and bringing in the new upstream specs etc.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

Go Published Test Results

1 948 tests   1 948 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit 55fc8f3.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (2355e8b) 81.47% compared to head (a012c3e) 81.47%.

❗ Current head a012c3e differs from pull request most recent head 55fc8f3. Consider uploading reports for the commit 55fc8f3 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2712   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files         133      133           
  Lines       20154    20154           
=======================================
  Hits        16421    16421           
  Misses       2881     2881           
  Partials      852      852

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

E2E Tests Published Test Results

    4 files      4 suites   3h 22m 1s ⏱️
  96 tests   87 ✔️   5 💤 4 ❌
392 runs  364 ✔️ 20 💤 8 ❌

For more details on these failures, see this check.

Results for commit 55fc8f3.

♻️ This comment has been updated with latest results.

@zachaller zachaller marked this pull request as ready for review April 13, 2023 13:50
@zachaller zachaller requested a review from leoluz April 13, 2023 13:50
leoluz
leoluz requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is introducing CRD changes. Is this intentional? Not sure I understand why this is required to update k8s deps. Maybe better to break this in 2 separate PRs?

@zachaller
fix wrong dep inclusion
55fc8f3 
Signed-off-by: zachaller <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@zachaller
Copy link
Collaborator Author

This PR is introducing CRD changes. Is this intentional? Not sure I understand why this is required to update k8s deps. Maybe better to break this in 2 separate PRs?

The reason there are crd changes is because we embed upstream k8s specs into various rollout objects and so when upstream k8s add's new fields we get them added to our crd's as well.

leoluz
leoluz approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 0a9c6f1 into argoproj:master Apr 28, 2023
@zachaller zachaller deleted the chore-bump-k8s-dep branch April 28, 2023 17:23
zachaller added a commit that referenced this pull request May 4, 2023
@zachaller
chore: bump k8s deps to v0.25.8 (#2712)
b81d682 
* bump to v0.24.12

Signed-off-by: zachaller <[email protected]>

* bump to v0.26.3

Signed-off-by: zachaller <[email protected]>

* bump to v0.25.8

Signed-off-by: zachaller <[email protected]>

* add new interface functions

Signed-off-by: zachaller <[email protected]>

* fix wrong dep inclusion

Signed-off-by: zachaller <[email protected]>

---------

Signed-off-by: zachaller <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-1.5 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachaller @leoluz