Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: copy argo cd docs drop down fix #2731

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Apr 18, 2023

Fix drop down via same pr argocd used argoproj/argo-cd#13102

@zachaller zachaller requested a review from leoluz April 18, 2023 08:11
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4cecf34) 81.47% compared to head (593f48f) 81.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2731   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files         133      133           
  Lines       20154    20154           
=======================================
  Hits        16421    16421           
  Misses       2881     2881           
  Partials      852      852           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Go Published Test Results

1 948 tests   1 948 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 593f48f.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 27m 49s ⏱️
  96 tests   81 ✔️   5 💤 10
396 runs  364 ✔️ 20 💤 12

For more details on these failures, see this check.

Results for commit 593f48f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit cc78ac5 into argoproj:master Apr 28, 2023
zachaller added a commit that referenced this pull request May 4, 2023
copy argo rollouts drop down fix for docs

Signed-off-by: zachaller <[email protected]>
zachaller added a commit that referenced this pull request May 4, 2023
copy argo rollouts drop down fix for docs

Signed-off-by: zachaller <[email protected]>
zachaller added a commit that referenced this pull request May 4, 2023
copy argo rollouts drop down fix for docs

Signed-off-by: zachaller <[email protected]>
zachaller added a commit that referenced this pull request May 4, 2023
copy argo rollouts drop down fix for docs

Signed-off-by: zachaller <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants