Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining custom annotations and labels for AnalysisRun #2740

Closed
lukaszgyg opened this issue Apr 24, 2023 · 0 comments
Closed

Allow defining custom annotations and labels for AnalysisRun #2740

lukaszgyg opened this issue Apr 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@lukaszgyg
Copy link
Contributor

Summary

I didn't find the way to define the custom metadata (labels or annotations) on the AnalysisRun resource.
Looking at the source code, I found the static creation for those properties.

This feature is going to address this limitation and allow the user to define the custom labels and annotations of AnalysisRun base on the Rollout template.

Use Cases

We recently introduced the ArgoCD external URL and our engineers liked that feature. For our ArgoCD resources we are generating the service specific links like (Kibana or Datadog).
One of our use cases is to provide the Kibana link for AnalysisRun with the version context. This will allow us to jump into the filtered logs for failing AnalysisRun.

This is our use case but, I can imagine other cases where we could use this feature to group/filter AnalysisRun resources.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant