Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically scale down Deployment after migrating to Rollout #2748

Closed
carlossg opened this issue Apr 25, 2023 · 2 comments · Fixed by #3111
Closed

Automatically scale down Deployment after migrating to Rollout #2748

carlossg opened this issue Apr 25, 2023 · 2 comments · Fixed by #3111
Labels
enhancement New feature or request no-issue-activity

Comments

@carlossg
Copy link
Contributor

Summary

When using Rollout with workloadRef it could be expected that the workload (Deployment) is scaled down as the Rollout is scaled up, or at the end after successful rollout

Use Cases

During migration of 10s-1000s of Deployments to Rollouts

After talking to several maintainers during ArgoCon this could be a new field under spec.workloadRef, maybe something like

spec:
  workloadRef:
    apiVersion: apps/v1
    kind: Deployment
    name: "acme"
    scaleDown: "never|onsuccess|progressively"
  • never: do not downscale
  • onsuccess: after successful rollout
  • progressively: as rollout is scaled up deployment is scaled down. If rollout fails then deployment is scaled back up to original replicas (I think this may be interesting for very large replica numbers, but maybe too early to say)

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@carlossg carlossg added the enhancement New feature or request label Apr 25, 2023
@zachaller
Copy link
Collaborator

I think this could make sense as long as the default behavior maintains backwards compatibility, which if scaleDown: nil or "" equates to never

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants