Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for Amazon Managed Prometheus #2777

Merged
merged 1 commit into from
May 14, 2023

Conversation

lewinkedrs
Copy link
Contributor

Checklist:

Adds a section in the docs for analysis using Amazon Managed Prometheus, which was added in #2458

  • [ c ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [ b ] The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [ x ] I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Kevin Lewin <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lewinkedrs lewinkedrs changed the title Add docs for Amazon Managed Prometheus docs: Add docs for Amazon Managed Prometheus May 12, 2023
@github-actions
Copy link
Contributor

Go Published Test Results

1 952 tests   1 952 ✔️  2m 36s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 3bb4991.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (2e66cd4) 81.64% compared to head (3bb4991) 81.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2777      +/-   ##
==========================================
- Coverage   81.64%   81.63%   -0.02%     
==========================================
  Files         133      133              
  Lines       20177    20177              
==========================================
- Hits        16474    16471       -3     
- Misses       2849     2852       +3     
  Partials      854      854              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 21m 23s ⏱️
  96 tests   84 ✔️   5 💤   7
394 runs  364 ✔️ 20 💤 10

For more details on these failures, see this check.

Results for commit 3bb4991.

@zachaller zachaller merged commit 13b988e into argoproj:master May 14, 2023
@danil-smirnov
Copy link
Contributor

Hi @lewinkedrs
I've checked the URL in the docs - https://docs.aws.amazon.com/prometheus/latest/userguide/AMP-onboard-ingest-metrics-new-Prometheus.html#AMP-onboard-new-Prometheus-IRSA - it doesn't look correct to me, it's about ingesting metrics to AMP but we need to query metrics instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants