ci: use keyless signing for main and release branches #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Marquis <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2783 +/- ##
=======================================
Coverage 81.64% 81.64%
=======================================
Files 133 133
Lines 20178 20178
=======================================
Hits 16475 16475
Misses 2849 2849
Partials 854 854 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Marquis <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
May 16, 2023
zachaller
approved these changes
May 17, 2023
zachaller
pushed a commit
that referenced
this pull request
May 24, 2023
* ci: use keyless signing for main and release branches Signed-off-by: Justin Marquis <[email protected]> * fix typo Signed-off-by: Justin Marquis <[email protected]> --------- Signed-off-by: Justin Marquis <[email protected]>
zachaller
pushed a commit
that referenced
this pull request
May 24, 2023
* ci: use keyless signing for main and release branches Signed-off-by: Justin Marquis <[email protected]> * fix typo Signed-off-by: Justin Marquis <[email protected]> --------- Signed-off-by: Justin Marquis <[email protected]>
zachaller
pushed a commit
that referenced
this pull request
May 24, 2023
* ci: use keyless signing for main and release branches Signed-off-by: Justin Marquis <[email protected]> * fix typo Signed-off-by: Justin Marquis <[email protected]> --------- Signed-off-by: Justin Marquis <[email protected]>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements using keyless signing for cosign. It uses a reusable workflow (image-reuse.yaml) that will also be used in the
releaseworkflow to generate attestations.Changes in
docker-publishworkflow:latesttag will be used,mastertag has been removed on a push events of themasterbranch.image-reuse.yamlis the exact same reusable workflow we are using in Argo CD.Successful testing of generating attestations for Argo Rollouts has been completed and will come in a separate PR along with all the documentation.
https://github.com/34fathombelow/rollouts-testing/actions/runs/4989497845
https://github.com/34fathombelow/rollouts-testing/releases/tag/v2.0.0-rc3