New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add unit test #2798

Merged

zachaller merged 2 commits into argoproj:master from yyzxw:chore/add-ut

May 22, 2023

Contributor

yyzxw commented May 21, 2023

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.


          chore: add unit test

Signed-off-by: yyzxw <[email protected]>

codecov bot commented May 21, 2023 •

edited

Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (2c9d032) 81.64% compared to head (a82dbc1) 81.68%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
+ Coverage   81.64%   81.68%   +0.03%     
==========================================
  Files         133      133              
  Lines       20178    20178              
==========================================
+ Hits        16475    16483       +8     
+ Misses       2849     2843       -6     
+ Partials      854      852       -2

Impacted Files	Coverage Δ
utils/experiment/experiment.go	`93.10% <ø> (ø)`
utils/replicaset/canary.go	`93.97% <100.00%> (+1.11%)`	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Contributor

github-actions bot commented May 21, 2023 •

edited

Loading

Go Published Test Results

1 983 tests 1 983 ✔️ 2m 37s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit a82dbc1.

♻️ This comment has been updated with latest results.

yyzxw changed the title ~~Chore: add unit test~~ chore: add unit test

Contributor

github-actions bot commented May 21, 2023 •

edited

Loading

E2E Tests Published Test Results

    4 files     4 suites 3h 24m 9s ⏱️
  96 tests   87 ✔️   5 💤 4 ❌
390 runs 364 ✔️ 20 💤 6 ❌

For more details on these failures, see this check.

Results for commit a82dbc1.

♻️ This comment has been updated with latest results.


          Merge branch 'master' into chore/add-ut

a82dbc1

sonarcloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

Contributor Author

yyzxw commented May 21, 2023

/retest

zachaller approved these changes

View reviewed changes

zachaller merged commit f1ae505 into argoproj:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet