Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo in header routing specification docs #2808

Merged
merged 2 commits into from
May 24, 2023

Conversation

mjallday
Copy link
Contributor

@mjallday mjallday commented May 24, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@mjallday mjallday marked this pull request as ready for review May 24, 2023 20:37
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

Go Published Test Results

1 983 tests   1 983 ✔️  2m 37s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 584f4a1.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e8d1117) 81.68% compared to head (584f4a1) 81.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2808   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files         133      133           
  Lines       20178    20178           
=======================================
  Hits        16483    16483           
  Misses       2843     2843           
  Partials      852      852           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 28m 45s ⏱️
  96 tests   80 ✔️   5 💤 11
400 runs  364 ✔️ 20 💤 16

For more details on these failures, see this check.

Results for commit 584f4a1.

@zachaller zachaller changed the title Fix typo in header routing specification docs docs: Fix typo in header routing specification docs May 24, 2023
@zachaller zachaller merged commit cf444ec into argoproj:master May 24, 2023
@mjallday mjallday deleted the patch-1 branch May 25, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants