Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add merge key to analysis template #2842

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jun 14, 2023

add analysis template merge key information

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Go Published Test Results

1 988 tests   1 988 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 9ab372e.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (194c656) 81.67% compared to head (9ab372e) 81.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2842   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files         133      133           
  Lines       20188    20188           
=======================================
  Hits        16489    16489           
  Misses       2847     2847           
  Partials      852      852           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment. Otherwise LGTM

pkg/apis/rollouts/v1alpha1/types.go Show resolved Hide resolved
@zachaller zachaller changed the title feat: add merge key to analysis args feat: add merge key to analysis templates Jun 14, 2023
@zachaller zachaller changed the title feat: add merge key to analysis templates feat: add merge key to RolloutAnalysisTemplate Jun 14, 2023
@zachaller zachaller changed the title feat: add merge key to RolloutAnalysisTemplate feat: add merge key to analysis template Jun 14, 2023
@zachaller zachaller enabled auto-merge (squash) June 14, 2023 16:04
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

@zachaller zachaller merged commit ded934b into argoproj:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants