Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout attribute for prometheus metrics provider #2892

Closed
AhmedGrati opened this issue Jul 19, 2023 · 0 comments · Fixed by #2893
Closed

Add timeout attribute for prometheus metrics provider #2892

AhmedGrati opened this issue Jul 19, 2023 · 0 comments · Fixed by #2893
Labels
analysis Related to Analysis CRD enhancement New feature or request

Comments

@AhmedGrati
Copy link
Contributor

Summary

Add timeout attribute in the Prometheus metric provider of the AnalysisTemplate. It would look something like this:

apiVersion: argoproj.io/v1alpha1
kind: AnalysisTemplate
metadata:
  name: success-rate
spec:
  args:
  - name: service-name
  metrics:
  - name: success-rate
    interval: 5m
    # NOTE: prometheus queries return results in the form of a vector.
    # So it is common to access the index 0 of the returned array to obtain the value
    successCondition: result[0] >= 0.95
    failureLimit: 3
    provider:
      prometheus:
        address: http://prometheus.example.com:9090
        timeout: 40

Use Cases

Can be useful when the query to the Prometheus server takes more than the default timeout which is 30 seconds.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@AhmedGrati AhmedGrati added the enhancement New feature or request label Jul 19, 2023
@kostis-codefresh kostis-codefresh added the analysis Related to Analysis CRD label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Related to Analysis CRD enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants