New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add insecure option for Prometheus. Fixes #2913 #2914

Merged

zachaller merged 2 commits into argoproj:master from OpenGuidou:Insecure-Prom

Aug 4, 2023

Contributor

OpenGuidou commented Jul 28, 2023 •

edited

Loading

Resolves #2913

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

OpenGuidou changed the title ~~feat: Add insecure option for Prometheus~~ feat: Add insecure option for Prometheus. Fixes #2913

codecov bot commented Jul 28, 2023 •

edited

Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (378e3d3) 81.75% compared to head (04d7ec5) 81.76%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2914   +/-   ##
=======================================
  Coverage   81.75%   81.76%           
=======================================
  Files         133      133           
  Lines       20338    20348   +10     
=======================================
+ Hits        16627    16637   +10     
  Misses       2855     2855           
  Partials      856      856

Files Changed	Coverage Δ
metricproviders/prometheus/prometheus.go	`88.59% <100.00%> (+0.82%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Contributor

github-actions bot commented Jul 28, 2023 •

edited

Loading

Go Published Test Results

2 033 tests 2 033 ✔️ 2m 39s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit 04d7ec5.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Jul 28, 2023 •

edited

Loading

E2E Tests Published Test Results

    4 files     4 suites 3h 50m 24s ⏱️
102 tests   83 ✔️   6 💤 13 ❌
436 runs 384 ✔️ 24 💤 28 ❌

For more details on these failures, see this check.

Results for commit 48e16e7.

♻️ This comment has been updated with latest results.

OpenGuidou force-pushed the Insecure-Prom branch 4 times, most recently from 62d3dc6 to b13764f Compare

July 28, 2023 11:14

zachaller reviewed

View reviewed changes

metricproviders/prometheus/prometheus.go Show resolved Hide resolved


          feat: Add insecure option for Prometheus

48e16e7

Signed-off-by: Guillaume Doussin <[email protected]>

zachaller force-pushed the Insecure-Prom branch from b13764f to 48e16e7 Compare

August 4, 2023 12:51


          change grpc id

04d7ec5

Signed-off-by: zachaller <[email protected]>

sonarcloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
56.3% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

zachaller approved these changes

View reviewed changes

zachaller enabled auto-merge (squash)

August 4, 2023 21:58

zachaller merged commit c9bc3bc into argoproj:master

20 of 21 checks passed

OpenGuidou mentioned this pull request

REQUEST: New membership for OpenGuidou argoproj/argoproj#291

Closed

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet