Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update supported k8s version #2949

Merged

Conversation

amazingandyyy
Copy link
Contributor

@amazingandyyy amazingandyyy commented Aug 10, 2023

We have many issues opened regarding the compatible issue of argo-rollouts and k8s. Based on @zachaller comment on this #2718 issue, I think we all agree:

  1. the old docs is unclear and not true, argo-rollouts doesn't only support k8s N and N-1 version, sometime it support N-3 version
  2. the code is truth; as long as it's tested, we should be able to say argo-rollouts X version is compatible with k8s Y version

Resolves #2718

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller zachaller enabled auto-merge (squash) August 10, 2023 23:19
@zachaller
Copy link
Collaborator

Thanks for the pr

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b81ca2) 81.74% compared to head (e010a5b) 81.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2949   +/-   ##
=======================================
  Coverage   81.74%   81.74%           
=======================================
  Files         134      134           
  Lines       20370    20370           
=======================================
  Hits        16652    16652           
  Misses       2861     2861           
  Partials      857      857           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Go Published Test Results

2 040 tests   2 040 ✔️  2m 39s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit e010a5b.

@zachaller zachaller merged commit 91cf2b1 into argoproj:master Aug 10, 2023
19 checks passed
@amazingandyyy amazingandyyy deleted the f/docs-supported-k8s-version branch August 11, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue
2 participants