Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trafficrouting): use values array for multiple accepted values under same header name #2974

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

schlags
Copy link
Contributor

@schlags schlags commented Aug 21, 2023

Fixes #2973

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Dylan Schlager <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fec76d6) 81.74% compared to head (2a26705) 81.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2974   +/-   ##
=======================================
  Coverage   81.74%   81.75%           
=======================================
  Files         134      134           
  Lines       20370    20377    +7     
=======================================
+ Hits        16652    16659    +7     
  Misses       2861     2861           
  Partials      857      857           
Files Changed Coverage Δ
rollout/trafficrouting/alb/alb.go 81.19% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Go Published Test Results

2 042 tests   2 042 ✔️  2m 41s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 2a26705.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 40m 20s ⏱️
102 tests   85 ✔️   6 💤 11
426 runs  385 ✔️ 24 💤 17

For more details on these failures, see this check.

Results for commit 2a26705.

♻️ This comment has been updated with latest results.

@zachaller zachaller merged commit f28d70c into argoproj:master Aug 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for multiple values to be passed to ALB traffic shaping header match condition
2 participants