Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename interface{} => any #3000

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

izturn
Copy link
Contributor

@izturn izturn commented Aug 31, 2023

Signed-off-by: Gang Liu [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 82.14% and no project coverage change.

Comparison is base (b14679b) 81.74% compared to head (533e86f) 81.74%.
Report is 1 commits behind head on master.

❗ Current head 533e86f differs from pull request most recent head 6e91150. Consider uploading reports for the commit 6e91150 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3000   +/-   ##
=======================================
  Coverage   81.74%   81.74%           
=======================================
  Files         134      134           
  Lines       20386    20386           
=======================================
  Hits        16665    16665           
  Misses       2865     2865           
  Partials      856      856           
Files Changed Coverage Δ
experiments/experiment.go 90.01% <ø> (ø)
rollout/restart.go 98.69% <ø> (ø)
rollout/trafficrouting/istio/controller.go 53.36% <0.00%> (ø)
server/server.go 0.00% <0.00%> (ø)
analysis/controller.go 63.46% <12.50%> (ø)
ingress/ingress.go 74.00% <20.00%> (ø)
service/service.go 78.51% <20.00%> (ø)
utils/json/json.go 33.33% <33.33%> (ø)
metricproviders/skywalking/skywalking.go 61.84% <50.00%> (ø)
experiments/controller.go 71.42% <56.25%> (ø)
... and 32 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Go Published Test Results

2 045 tests   2 045 ✔️  2m 41s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 6e91150.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 39m 4s ⏱️
102 tests   87 ✔️   6 💤   9
420 runs  385 ✔️ 24 💤 11

For more details on these failures, see this check.

Results for commit 6e91150.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.9% 6.9% Duplication

@zachaller zachaller merged commit 69bcc37 into argoproj:master Sep 5, 2023
22 checks passed
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 13, 2023
* rename interface{} => any

Signed-off-by: gang.liu <[email protected]>

* revert change to generated code

Signed-off-by: gang.liu <[email protected]>

---------

Signed-off-by: gang.liu <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
* rename interface{} => any

Signed-off-by: gang.liu <[email protected]>

* revert change to generated code

Signed-off-by: gang.liu <[email protected]>

---------

Signed-off-by: gang.liu <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants