Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove rogue apostrophe in features/analysis.md #3001

Merged
merged 1 commit into from
Aug 31, 2023
Merged

docs: Remove rogue apostrophe in features/analysis.md #3001

merged 1 commit into from
Aug 31, 2023

Conversation

stig
Copy link
Contributor

@stig stig commented Aug 31, 2023 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (f433582) 81.75% compared to head (4ba256a) 81.75%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3001   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         134      134           
  Lines       20377    20377           
=======================================
  Hits        16659    16659           
  Misses       2861     2861           
  Partials      857      857

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

Go Published Test Results

2 042 tests   2 042 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit 4ba256a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

E2E Tests Published Test Results

    4 files      4 suites   3h 45m 2s ⏱️
102 tests   89 ✔️   6 💤   7 ❌
422 runs  384 ✔️ 24 💤 14 ❌

For more details on these failures, see this check.

Results for commit 4ba256a.

♻️ This comment has been updated with latest results.

@stig stig changed the title docs(features/analysis.md): Remove rogue apostrophe docs: Remove rogue apostrophe in features/analysis.md Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller zachaller merged commit c5508fb into argoproj:master Aug 31, 2023
22 checks passed
@stig stig deleted the typofix branch September 1, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stig @zachaller