Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo Rollouts 1.6.0 UI Comments #3051

Closed
DanTulovsky opened this issue Sep 22, 2023 · 9 comments
Closed

Argo Rollouts 1.6.0 UI Comments #3051

DanTulovsky opened this issue Sep 22, 2023 · 9 comments
Labels
enhancement New feature or request ui

Comments

@DanTulovsky
Copy link

Summary

Hi. I wanted to give some feedback on the new Rollouts 1.6.0 UI.

Overall, thank you very much, it's much better. I have two specific improvements that perhaps you would consider.

  1. The landing page has a box for each Rollout on it. I think it would be much easier to look at it if each Rollout was on its own line. You should easily be able to fit the same information and it would allow things like sorting on status.

  2. A very common use case for me is to look at the progress of multiple related Rollouts. For example:

image

It used to be the case that this view would show the progress as well (the green boxes). It no longer does this, which means I have to click into each one for status.

Thank you!

Use Cases

When would you use this?


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@DanTulovsky DanTulovsky added the enhancement New feature or request label Sep 22, 2023
@phclark
Copy link
Contributor

phclark commented Oct 3, 2023

We have a similar ask in our organization. We have several hundred Rollouts, and it's difficult for engineers to follow progress on coordinated deployments involving many rollouts. It would be great to have several different view options so that we could get a view of the global state at a glance.

@phclark
Copy link
Contributor

phclark commented Oct 5, 2023

If no one else is working on this, I'd love to take a pass at it.

@phclark
Copy link
Contributor

phclark commented Oct 11, 2023

I've got a few screenshots for comment, would love some feedback!

The major changes I'm planning are:

  • Additional filters in the toolbar which allow the user to filter by status as well as a "meta" status "Needs Attention" which is defined as Rollouts with degraded status or paused where the pause message is not "CanaryPauseStep".
  • Ability to Favorite a Rollout, which will make the Rollout appear at the top of the screen. You can also filter to show only Favorites.
  • Added Rollout Message to the bottom of the Rollout cards
  • Improved name filtering to allow filtering of multiple rollouts ("frontend,backend" will return rollouts containing both terms in their name)
  • Added display mode selection to toolbar
  • Create new table display mode with sortable columns

New toolbar:
image

Message shown on bottom of card for easy identification of important status conditions
image

New table view
image

@DanTulovsky
Copy link
Author

I love all of these ideas!

@zachaller
Copy link
Collaborator

@phclark looks good, are the screenshots mockups or do you have a working PR?

@phclark
Copy link
Contributor

phclark commented Oct 11, 2023

@zachaller I can throw up a working PR :)

@phclark
Copy link
Contributor

phclark commented Oct 11, 2023

This is still a WIP, and the code likely needs to be cleaned up a air amount, but it should give you an idea of the approach I'm taking. Note that I'm more of an infra engineer than frontend dev, so if you see anything that needs improvement don't be shy :)

#3097

@martynd
Copy link
Contributor

martynd commented Dec 15, 2023

Noticed the latest changes when running a test build and was pleasantly surprised.
Definitely a worthwhile improvement

@zachaller
Copy link
Collaborator

Closed by: #3118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
None yet
Development

No branches or pull requests

5 participants