-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing rollout fields #3062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh16
changed the title
chores: add missing rollout fields
chore: add missing rollout fields
Sep 27, 2023
ashutosh16
force-pushed
the
missing-fields
branch
from
September 27, 2023 21:35
91179b8
to
e78a1d6
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3062 +/- ##
==========================================
- Coverage 81.71% 81.71% -0.01%
==========================================
Files 134 134
Lines 20416 20432 +16
==========================================
+ Hits 16683 16695 +12
- Misses 2873 2876 +3
- Partials 860 861 +1
☔ View full report in Codecov by Sentry. |
zachaller
reviewed
Sep 30, 2023
ashutosh16
force-pushed
the
missing-fields
branch
from
October 3, 2023 19:56
faff4b5
to
5ac4a48
Compare
ashutosh16
force-pushed
the
missing-fields
branch
3 times, most recently
from
October 3, 2023 22:22
cc9bd37
to
210845a
Compare
zachaller
reviewed
Oct 4, 2023
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
ashutosh16
force-pushed
the
missing-fields
branch
from
October 12, 2023 16:59
41976e8
to
a196c80
Compare
Signed-off-by: ashutosh16 <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
zachaller
approved these changes
Oct 13, 2023
zachaller
pushed a commit
that referenced
this pull request
Oct 25, 2023
* chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]>
zachaller
added
the
cherry-pick-completed
Used once we have cherry picked the PR to all requested releases
label
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick/release-1.6
cherry-pick-completed
Used once we have cherry picked the PR to all requested releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AnalysisInfo
https://gist.github.com/ashutosh16/5c6583f2e177ad7d8f7c44fda9dce015
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.