Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Ensure image not present between incomplete sentence. #3079

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

PranitRout07
Copy link
Contributor

@PranitRout07 PranitRout07 commented Oct 5, 2023

ISSUE DETAILS
Image is present between the incomplete sentence. To see the issue go to this link : https://argo-rollouts.readthedocs.io/en/stable/features/anti-affinity/anti-affinity/#enabling-anti-affinity-in-rollouts and check the above image.

image_bet_sentence

Commits:
3c83b2d
905af66

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ba7c9a5) 81.71% compared to head (854fa9c) 81.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3079   +/-   ##
=======================================
  Coverage   81.71%   81.71%           
=======================================
  Files         134      134           
  Lines       20416    20416           
=======================================
  Hits        16683    16683           
  Misses       2873     2873           
  Partials      860      860           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Go Published Test Results

2 045 tests   2 045 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 854fa9c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 38m 8s ⏱️
102 tests   89 ✔️   6 💤   7
426 runs  385 ✔️ 24 💤 17

For more details on these failures, see this check.

Results for commit 854fa9c.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.3% 10.3% Duplication

@zachaller zachaller merged commit e788a01 into argoproj:master Oct 11, 2023
22 checks passed
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 13, 2023
…#3079)

* Update anti-affinity.md

* Update mkdocs.yml

Signed-off-by: Philip Clark <[email protected]>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
…#3079)

* Update anti-affinity.md

* Update mkdocs.yml

Signed-off-by: Philip Clark <[email protected]>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
…#3079)

* Update anti-affinity.md

* Update mkdocs.yml

Signed-off-by: Philip Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants