fix: bump notification-engine to fix double send on self server notifications #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachaller <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3095 +/- ##
=======================================
Coverage 81.71% 81.71%
=======================================
Files 134 134
Lines 20416 20416
=======================================
Hits 16683 16683
Misses 2873 2873
Partials 860 860 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zachaller <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…ications (argoproj#3095) * bump notification-engine to fix double send on self server notifications Signed-off-by: zachaller <[email protected]> * codegen Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]> Signed-off-by: Philip Clark <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…ications (argoproj#3095) * bump notification-engine to fix double send on self server notifications Signed-off-by: zachaller <[email protected]> * codegen Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]> Signed-off-by: Philip Clark <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…ications (argoproj#3095) * bump notification-engine to fix double send on self server notifications Signed-off-by: zachaller <[email protected]> * codegen Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]>
zachaller
added a commit
that referenced
this pull request
Oct 25, 2023
…ications (#3095) * bump notification-engine to fix double send on self server notifications Signed-off-by: zachaller <[email protected]> * codegen Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a notification engine bug to prevent double sending of notifications
Includes this: argoproj/notifications-engine@2d2d1a7