Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising managed routes #3155

Open
artem-nefedov opened this issue Nov 6, 2023 · 1 comment
Open

Allow customising managed routes #3155

artem-nefedov opened this issue Nov 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@artem-nefedov
Copy link

artem-nefedov commented Nov 6, 2023

Summary

Managed routes created by argo-rollouts will often lack important fields, making features like setHeaderRoute and setMirrorRoute significantly less usable than they could be. The request is to allow customising what fields will be added to created route.

This can be done by either explicitly defining custom fields that will be merged in into generated route, or being able to specify "reference" route to read fields from. In case of first option, it's important to be able to customise routes in different virtual services individually (second option does that automatically).

I think this may be relevant, but I'm not completely sure since I don't have an access to Slack: #2073 (comment)

Use Cases

We use Istio, and for ingress traffic we use prefix match and rewrite functionality, and it's crucial for prefix match and rewrite to be present for all routes in VirtualService that is bound to ingress gateway. We also have a separate VirtualService for internal traffic only (no gateways), and argo-rollouts manages both of them. For local VirtualService, rewrite is not needed.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@artem-nefedov artem-nefedov added the enhancement New feature or request label Nov 6, 2023
@eduardobaitello
Copy link

Is this enhancement being considered for a future version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants