Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support AnalysisRunMetadata and Dryrun for experiments via Rollout #3213

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Dec 5, 2023

Fixes #3209

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@OpenGuidou OpenGuidou force-pushed the Experiment branch 2 times, most recently from a18c8e9 to 34badf8 Compare December 5, 2023 07:54
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c492b06) 81.82% compared to head (a13bc53) 81.86%.

Files Patch % Lines
experiments/experiment.go 80.55% 5 Missing and 2 partials ⚠️
rollout/analysis.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
+ Coverage   81.82%   81.86%   +0.03%     
==========================================
  Files         135      135              
  Lines       20688    20712      +24     
==========================================
+ Hits        16928    16955      +27     
+ Misses       2886     2883       -3     
  Partials      874      874              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Go Published Test Results

2 109 tests   2 109 ✅  2m 50s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit a13bc53.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

E2E Tests Published Test Results

  4 files    4 suites   3h 27m 8s ⏱️
106 tests  95 ✅  6 💤  5 ❌
436 runs  401 ✅ 24 💤 11 ❌

For more details on these failures, see this check.

Results for commit a13bc53.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
4.8% 4.8% Duplication

@OpenGuidou
Copy link
Contributor Author

Hi @zachaller ,
Can I please get a review on this one ?

@OpenGuidou
Copy link
Contributor Author

Hi @zachaller , could I get a review on this one ?

@zachaller zachaller added this to the v1.7 milestone Jan 7, 2024
@OpenGuidou OpenGuidou force-pushed the Experiment branch 2 times, most recently from 18dc5a6 to 4eaf7ff Compare January 30, 2024 08:23
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
31.9% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller merged commit fcb88f0 into argoproj:master Feb 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add analysisRunMetadata and dryrun support to experiments
2 participants