Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Analysis run to rollout notifications #3296

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

ashutosh16
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Go Published Test Results

2 141 tests   2 141 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 962e550.

♻️ This comment has been updated with latest results.

@ashutosh16 ashutosh16 changed the title add Analysis run to rollout notifications fix:add Analysis run to rollout notifications Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 42m 42s ⏱️
108 tests  95 ✅  6 💤 7 ❌
442 runs  409 ✅ 24 💤 9 ❌

For more details on these failures, see this check.

Results for commit 962e550.

♻️ This comment has been updated with latest results.

@ashutosh16 ashutosh16 changed the title fix:add Analysis run to rollout notifications fix: add Analysis run to rollout notifications Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: Patch coverage is 75.40984% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 82.87%. Comparing base (8405f2e) to head (701a6cd).
Report is 41 commits behind head on master.

❗ Current head 701a6cd differs from pull request most recent head 962e550. Consider uploading reports for the commit 962e550 to get more accurate results

Files Patch % Lines
utils/record/record.go 71.11% 9 Missing and 4 partials ⚠️
utils/annotations/annotations.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3296      +/-   ##
==========================================
+ Coverage   81.83%   82.87%   +1.03%     
==========================================
  Files         135      135              
  Lines       20688    16973    -3715     
==========================================
- Hits        16931    14067    -2864     
+ Misses       2883     2024     -859     
- Partials      874      882       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashutosh16 ashutosh16 force-pushed the analysisRun-notifications branch 3 times, most recently from a303280 to bc9440d Compare January 16, 2024 01:58
@ashutosh16 ashutosh16 force-pushed the analysisRun-notifications branch 2 times, most recently from 9d4b52c to 1e38911 Compare January 19, 2024 01:43
utils/record/record.go Outdated Show resolved Hide resolved
@zachaller zachaller added this to the v1.7 milestone Jan 25, 2024
@zachaller zachaller changed the title fix: add Analysis run to rollout notifications feat: add Analysis run to rollout notifications Jan 26, 2024
@ashutosh16 ashutosh16 force-pushed the analysisRun-notifications branch 4 times, most recently from 91d428a to 6b4d64b Compare January 30, 2024 18:03
@ashutosh16 ashutosh16 marked this pull request as ready for review January 30, 2024 18:10
utils/record/record.go Outdated Show resolved Hide resolved
utils/record/record.go Outdated Show resolved Hide resolved
utils/record/record.go Outdated Show resolved Hide resolved
utils/record/record.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
9.5% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller merged commit 5018705 into argoproj:master Mar 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants