Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update follow-redirects to 1.15.5 #3314

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

reginapizza
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

This PR addresses a CVE for follow-redirects: https://security.snyk.io/vuln/SNYK-JS-FOLLOWREDIRECTS-6141137
It's a transitive dependency only but better to just update it anyway.

@reginapizza reginapizza changed the title update follow-redirects to 1.15.5 chore: update follow-redirects to 1.15.5 Jan 17, 2024
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit c747712.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (180b4bf) 81.83% compared to head (c747712) 81.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
- Coverage   81.83%   81.82%   -0.02%     
==========================================
  Files         135      135              
  Lines       20633    20633              
==========================================
- Hits        16885    16882       -3     
- Misses       2877     2880       +3     
  Partials      871      871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 32m 20s ⏱️
106 tests  94 ✅  6 💤  6 ❌
440 runs  400 ✅ 24 💤 16 ❌

For more details on these failures, see this check.

Results for commit c747712.

@zachaller zachaller merged commit d9f9853 into argoproj:master Jan 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants