Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logging context around replicaset updates #3326

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

zachaller
Copy link
Collaborator

Add logging context around replicaset updates

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit f368ae5.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (d77d189) 81.82% compared to head (f368ae5) 81.77%.

Files Patch % Lines
rollout/sync.go 0.00% 6 Missing and 1 partial ⚠️
rollout/canary.go 0.00% 5 Missing and 1 partial ⚠️
rollout/bluegreen.go 0.00% 4 Missing and 1 partial ⚠️
rollout/replicaset.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3326      +/-   ##
==========================================
- Coverage   81.82%   81.77%   -0.06%     
==========================================
  Files         135      135              
  Lines       20637    20646       +9     
==========================================
- Hits        16886    16883       -3     
- Misses       2879     2888       +9     
- Partials      872      875       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 25m 34s ⏱️
106 tests  98 ✅  6 💤 2 ❌
426 runs  400 ✅ 24 💤 2 ❌

For more details on these failures, see this check.

Results for commit f368ae5.

@zachaller zachaller merged commit 1a332e3 into argoproj:master Jan 25, 2024
22 of 23 checks passed
zachaller added a commit that referenced this pull request Jan 25, 2024
* chore: add more logging

Signed-off-by: Zach Aller <[email protected]>

* chore: remove accidental files

Signed-off-by: Zach Aller <[email protected]>

---------

Signed-off-by: Zach Aller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants