Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump notification engine lib #3327

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jan 25, 2024

This will give us retries on notification engine webhooks

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a332e3) 81.77% compared to head (3b7641c) 81.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3327      +/-   ##
==========================================
+ Coverage   81.77%   81.78%   +0.01%     
==========================================
  Files         135      135              
  Lines       20646    20646              
==========================================
+ Hits        16883    16886       +3     
+ Misses       2888     2885       -3     
  Partials      875      875              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 3b7641c.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller enabled auto-merge (squash) January 25, 2024 19:21
@zachaller zachaller merged commit a07417a into argoproj:master Jan 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants