Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change controller's deploy strategy to RollingUpdate due to leader election #3334

Merged

Conversation

yu-croco
Copy link
Contributor

@yu-croco yu-croco commented Jan 27, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

background

Though there was a constraint to use deployment strategy Recreate due to race condition #38, now it seems we don't have to care about deployment strategy as below.

https://cloud-native.slack.com/archives/C01U781DW2E/p1640199673233000
image

argo-helm got the PR that let controller's deployment strategy configurable, so I wonder we can change the default strategy as RollingUpdate. 🙋

@yu-croco yu-croco force-pushed the configurable-controller-deploy-strategy branch from c56d3a0 to 0406ff8 Compare January 27, 2024 01:14
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yu-croco yu-croco changed the title chore: change deploy strategy due to controller's leader election chore: change controller's deploy strategy due to leader election Jan 27, 2024
Copy link
Contributor

Go Published Test Results

2 097 tests   2 097 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 0406ff8.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (723f7a9) 81.79% compared to head (0406ff8) 81.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3334      +/-   ##
==========================================
- Coverage   81.79%   81.77%   -0.02%     
==========================================
  Files         135      135              
  Lines       20649    20649              
==========================================
- Hits        16889    16886       -3     
- Misses       2885     2888       +3     
  Partials      875      875              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yu-croco yu-croco changed the title chore: change controller's deploy strategy due to leader election chore: change controller's deploy strategy to RollingUpdate to leader election Jan 27, 2024
@yu-croco yu-croco changed the title chore: change controller's deploy strategy to RollingUpdate to leader election chore: change controller's deploy strategy to RollingUpdate due to leader election Jan 27, 2024
Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 29m 15s ⏱️
106 tests  98 ✅  6 💤  2 ❌
438 runs  400 ✅ 24 💤 14 ❌

For more details on these failures, see this check.

Results for commit 0406ff8.

@yu-croco yu-croco marked this pull request as ready for review January 27, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants