Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Guides for popular use-cases #3346

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

kostis-codefresh
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Kostis Kapelonis <[email protected]>
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kostis-codefresh kostis-codefresh added the docs Needs documentation/release notes label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Go Published Test Results

2 106 tests   2 106 ✅  2m 50s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit e3a6f4a.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 31m 19s ⏱️
106 tests  95 ✅  6 💤  5 ❌
448 runs  398 ✅ 24 💤 26 ❌

For more details on these failures, see this check.

Results for commit e3a6f4a.

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👌

@zachaller zachaller enabled auto-merge (squash) February 3, 2024 18:13
@zachaller zachaller merged commit 6efb3cc into argoproj:master Feb 3, 2024
19 checks passed
@kostis-codefresh kostis-codefresh deleted the best-practices branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Needs documentation/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants