Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting traefik versions #3348

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Feb 2, 2024

Checklist:
Fixes #3119

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Go Published Test Results

2 124 tests   2 124 ✅  2m 50s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit c23ab55.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (8405f2e) 81.83% compared to head (c23ab55) 82.89%.
Report is 11 commits behind head on master.

Files Patch % Lines
controller/controller.go 21.68% 61 Missing and 4 partials ⚠️
utils/record/record.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
+ Coverage   81.83%   82.89%   +1.05%     
==========================================
  Files         135      135              
  Lines       20688    16853    -3835     
==========================================
- Hits        16931    13970    -2961     
+ Misses       2883     2009     -874     
  Partials      874      874              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 44m 16s ⏱️
107 tests  95 ✅  6 💤  6 ❌
440 runs  404 ✅ 24 💤 12 ❌

For more details on these failures, see this check.

Results for commit c23ab55.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller merged commit cf1ab9f into argoproj:master Feb 13, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for traefik.io api group version
2 participants