feat: allow analysis run to use separate kubeconfig for jobs

[gdsoumya]

Fixes #3337

This PR :

1. Enables setting ARGO_ROLLOUTS_ANALYSIS_JOB_KUBECONFIG to specify custom k8s config for running analysis jobs.
2. Also provides ARGO_ROLLOUTS_ANALYSIS_JOB_NAMESPACE to specify a different namespace from the analysis run to execute the job.

NOTE:

Setting custom ARGO_ROLLOUTS_ANALYSIS_JOB_NAMESPACE and ARGO_ROLLOUTS_ANALYSIS_JOB_KUBECONFIG will prevent automatic GC of jobs when analysis runs are deleted.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[github-actions]

Go Published Test Results

2 130 tests   2 130 ✅  2m 50s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 96b2c37.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (8405f2e) 81.83% compared to head (96b2c37) 82.92%.
Report is 17 commits behind head on master.

Files	Patch %	Lines
analysis/controller.go	0.00%	14 Missing ⚠️
metricproviders/job/job.go	81.81%	3 Missing and 3 partials ⚠️
pkg/kubectl-argo-rollouts/info/analysisrun_info.go	60.00%	1 Missing and 1 partial ⚠️
utils/controller/controller.go	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
+ Coverage   81.83%   82.92%   +1.08%     
==========================================
  Files         135      135              
  Lines       20688    16904    -3784     
==========================================
- Hits        16931    14017    -2914     
+ Misses       2883     2010     -873     
- Partials      874      877       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E Tests Published Test Results

  4 files    4 suites   3h 39m 13s ⏱️
107 tests  97 ✅  6 💤 4 ❌
434 runs  404 ✅ 24 💤 6 ❌

For more details on these failures, see this check.

Results for commit 96b2c37.

♻️ This comment has been updated with latest results.

[jessesuen]

I did a careful review of this one and could not find anything. This LGTM!

[jessesuen]

@zachaller did you want a chance to review this before merging? FWIW, we have also done manual, end-to-end testing of the feature.

[zachaller]

I will take deeper look tomorrow, however one of my first thoughts is consistency with ENV var naming. Due to past conventions both plugins and various metric providers use ARGO_ROLLOUTS_ prefixes for env vars. I lean towards keeping consistent with that even though this somewhat piggy backs off of kubeclients KUBECONFIG env var. I tend to always prefer consistency though. Thoughts?

[gdsoumya]

I will take deeper look tomorrow, however one of my first thoughts is consistency with ENV var naming. Due to past conventions both plugins and various metric providers use ARGO_ROLLOUTS_ prefixes for env vars. I lean towards keeping consistent with that even though this somewhat piggy backs off of kubeclients KUBECONFIG env var. I tend to always prefer consistency though. Thoughts?

Would you prefer ARGO_ROLLOUT_ANALYSIS_JOB_KUBECONFIG and ARGO_ROLLOUTS_ANALYSIS_JOB_NAMESPACE ? I dropped the prefix as the env was getting a bit long and also because we recently added the only analysis mode which makes it a standalone feature so thought just having ANALYSIS_ prefix might work. Though I don't have a strong opinion on this and if you and @jessesuen feel a bigger env name isn't an issue I'll add it.

[jessesuen]

Thanks @zachaller, that's a great call out. I agree the ARGO_ROLLOUTS_ prefix is an important convention to keep. So despite the long name, let's use that.

[gdsoumya]

Updated env names

[sonarcloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[zachaller]

LGTM