Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Consul plugin support to website #3362

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

wilkermichael
Copy link
Contributor

@wilkermichael wilkermichael commented Feb 12, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@wilkermichael
Copy link
Contributor Author

@thisisnotashwin

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (8405f2e) 81.83% compared to head (51982c4) 82.96%.
Report is 15 commits behind head on master.

Files Patch % Lines
controller/controller.go 21.68% 61 Missing and 4 partials ⚠️
utils/record/record.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3362      +/-   ##
==========================================
+ Coverage   81.83%   82.96%   +1.12%     
==========================================
  Files         135      135              
  Lines       20688    16854    -3834     
==========================================
- Hits        16931    13983    -2948     
+ Misses       2883     1999     -884     
+ Partials      874      872       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Go Published Test Results

2 124 tests   2 124 ✅  2m 50s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 51982c4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 40m 54s ⏱️
107 tests  98 ✅  6 💤 3 ❌
432 runs  404 ✅ 24 💤 4 ❌

For more details on these failures, see this check.

Results for commit 51982c4.

♻️ This comment has been updated with latest results.

@zachaller zachaller changed the title added Consul plugin support to website docs: added Consul plugin support to website Feb 13, 2024
* Provide support for Gateway API, which includes Kuma, Traefix, cilium, Contour, GloodMesh, HAProxy, and [many others](https://gateway-api.sigs.k8s.io/implementations/#implementation-status).

#### [Consul](https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-consul)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we alphabetize this.

@wilkermichael wilkermichael marked this pull request as ready for review February 13, 2024 21:44
Signed-off-by: Michael Wilkerson <[email protected]>
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zachaller zachaller merged commit f89b3d4 into argoproj:master Feb 27, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants