-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: job metrics owner ref when using custom job kubeconfig/ns #3425
Conversation
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
… into fix/job_owner_ref
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
@gdsoumya can we fix the conflict that should also re-trigger the tests |
Go Published Test Results2 142 tests 2 142 ✅ 2m 51s ⏱️ Results for commit 42baa82. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3425 +/- ##
==========================================
+ Coverage 81.83% 82.79% +0.95%
==========================================
Files 135 135
Lines 20688 16998 -3690
==========================================
- Hits 16931 14074 -2857
+ Misses 2883 2037 -846
- Partials 874 887 +13 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 43m 20s ⏱️ For more details on these failures, see this check. Results for commit 42baa82. ♻️ This comment has been updated with latest results. |
…ob_owner_ref Signed-off-by: Zach Aller <[email protected]>
Quality Gate passedIssues Measures |
This PR fixes the owner ref for jobs created using a custom kubeconfig or in a different ns from the analysis run. This is needed because k8s considers the owner ref invalid if the parent is not present in the same namespace as the child and garbage collects the job before it can finish.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.