Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job metrics owner ref when using custom job kubeconfig/ns #3425

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Mar 5, 2024

This PR fixes the owner ref for jobs created using a custom kubeconfig or in a different ns from the analysis run. This is needed because k8s considers the owner ref invalid if the parent is not present in the same namespace as the child and garbage collects the job before it can finish.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@zachaller zachaller added this to the v1.7 milestone Mar 6, 2024
@zachaller
Copy link
Collaborator

@gdsoumya can we fix the conflict that should also re-trigger the tests

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Go Published Test Results

2 142 tests   2 142 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 42baa82.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 82.79%. Comparing base (8405f2e) to head (42baa82).
Report is 47 commits behind head on master.

Files Patch % Lines
analysis/controller.go 0.00% 13 Missing ⚠️
metricproviders/job/job.go 68.42% 2 Missing and 4 partials ⚠️
utils/controller/controller.go 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
+ Coverage   81.83%   82.79%   +0.95%     
==========================================
  Files         135      135              
  Lines       20688    16998    -3690     
==========================================
- Hits        16931    14074    -2857     
+ Misses       2883     2037     -846     
- Partials      874      887      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 43m 20s ⏱️
108 tests  98 ✅  6 💤 4 ❌
440 runs  408 ✅ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit 42baa82.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
12.1% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller merged commit 0f52c93 into argoproj:master Mar 15, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants