Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose secrets for notification templates (#3455) #3466

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

eroznik
Copy link
Contributor

@eroznik eroznik commented Mar 23, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (8405f2e) to head (50880d6).
Report is 58 commits behind head on master.

❗ Current head 50880d6 differs from pull request most recent head 297c47c. Consider uploading reports for the commit 297c47c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3466      +/-   ##
==========================================
+ Coverage   81.83%   82.80%   +0.96%     
==========================================
  Files         135      135              
  Lines       20688    17005    -3683     
==========================================
- Hits        16931    14081    -2850     
+ Misses       2883     2037     -846     
- Partials      874      887      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

Go Published Test Results

2 144 tests   2 144 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 297c47c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 45m 59s ⏱️
110 tests  98 ✅  6 💤  6 ❌
452 runs  416 ✅ 24 💤 12 ❌

For more details on these failures, see this check.

Results for commit 297c47c.

♻️ This comment has been updated with latest results.

@zachaller zachaller added this to the v1.7 milestone Mar 26, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller merged commit 86a2df6 into argoproj:master Mar 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants