Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue that when max weight is 100000000, and the replicas> 20, the trafficWeightToReplicas will return negative value. #3474

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

andyliuliming
Copy link
Contributor

@andyliuliming andyliuliming commented Mar 26, 2024

when we set the max weight as 100000000, and when the replicas set to > 20. then the trafficWeightToReplicas will be a negative value.
and cause the rollout to stuck in the "min" replicas.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
9.7% Duplication on New Code

See analysis details on SonarCloud

@andyliuliming andyliuliming changed the title fix: when max weight is 100000000, the replicas can be negative. fix: fix the issue that when max weight is 100000000, and the replicas> 20, the trafficWeightToReplicas will return negative value. Mar 26, 2024
@zachaller
Copy link
Collaborator

LGTM: https://go.dev/play/p/cV3mbPUOZpa

@zachaller zachaller enabled auto-merge (squash) March 26, 2024 15:12
Copy link
Contributor

Go Published Test Results

2 142 tests   2 142 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 47cfdea.

@zachaller zachaller merged commit b427415 into argoproj:master Mar 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants