Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set webpack hashFunction to modern sha256, remove legacy-provider. Fixes #2609 #3475

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

xnox
Copy link
Contributor

@xnox xnox commented Mar 26, 2024

Fixes #2609

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

This is volunteer work to remove obsolete cryptography from all open source projects. See https://github.com/sponsors/xnox for more details.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Go Published Test Results

2 144 tests   2 144 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit ea276f0.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@xnox
Copy link
Contributor Author

xnox commented Mar 26, 2024

Alternative to this proposal is to upgrade to much newer webpack (v5 or higher) and then set hashFuction to one of the fast available options.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.78%. Comparing base (8405f2e) to head (ea276f0).
Report is 57 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3475      +/-   ##
==========================================
+ Coverage   81.83%   82.78%   +0.94%     
==========================================
  Files         135      135              
  Lines       20688    17001    -3687     
==========================================
- Hits        16931    14075    -2856     
+ Misses       2883     2037     -846     
- Partials      874      889      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 51m 15s ⏱️
110 tests  99 ✅  6 💤  5 ❌
470 runs  416 ✅ 24 💤 30 ❌

For more details on these failures, see this check.

Results for commit ea276f0.

@zachaller
Copy link
Collaborator

thank you for this fix, much cleaner than the workaround

@zachaller zachaller merged commit 633819b into argoproj:master Mar 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove temporary openssl-legacy-provider for nodejs ui build
2 participants