Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Corrects the logic of comparing sha256 has. Fixes #3519 #3520

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dhawani
Copy link
Contributor

@dhawani dhawani commented Apr 10, 2024

fixes: #3519

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@dhawani dhawani force-pushed the master branch 2 times, most recently from c66899a to f843bcb Compare April 10, 2024 09:01
Signed-off-by: dhawani <[email protected]>
Signed-off-by: dhawani <[email protected]>
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dhawani dhawani mentioned this pull request Apr 10, 2024
2 tasks
Copy link
Contributor

Go Published Test Results

2 160 tests   2 160 ✅  2m 53s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit f633855.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (8405f2e) to head (f633855).
Report is 91 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3520      +/-   ##
==========================================
- Coverage   81.83%   78.21%   -3.63%     
==========================================
  Files         135      158      +23     
  Lines       20688    18397    -2291     
==========================================
- Hits        16931    14389    -2542     
- Misses       2883     3101     +218     
- Partials      874      907      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 23m 37s ⏱️
110 tests  98 ✅  6 💤 6 ❌
446 runs  416 ✅ 24 💤 6 ❌

For more details on these failures, see this check.

Results for commit f633855.

@zachaller zachaller merged commit e90a601 into argoproj:master Apr 10, 2024
24 of 25 checks passed
zachaller pushed a commit that referenced this pull request Apr 10, 2024
 (#3520)

Fixed sha256 algo

Signed-off-by: dhawani <[email protected]>
Signed-off-by: dhawani <[email protected]>
Co-authored-by: dhawani <[email protected]>
zachaller pushed a commit that referenced this pull request Apr 10, 2024
 (#3520)

Fixed sha256 algo

Signed-off-by: dhawani <[email protected]>
Signed-off-by: dhawani <[email protected]>
Co-authored-by: dhawani <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.6 cherry-pick/release-1.7 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sha256 evaluation is incorrect
2 participants